Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fleetshard add-on and cleanup standalone provider #1486

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Remove fleetshard add-on and cleanup standalone provider #1486

merged 2 commits into from
Nov 21, 2023

Conversation

SimonBaeumer
Copy link
Member

Description

Remove fleetshard add-on and cleanup standalone provider

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

  • CI

@SimonBaeumer SimonBaeumer requested a review from ebensh November 20, 2023 13:12
@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Nov 21, 2023
@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,ebensh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer force-pushed the sb/clean-up-standalone-provider branch from 1787747 to 5f1acdf Compare November 21, 2023 12:00
@openshift-ci openshift-ci bot removed the lgtm label Nov 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

New changes are detected. LGTM label has been removed.

@SimonBaeumer
Remove fleetshard add-on and cleanup standalone provider
8f0e24d 
Remove Install dinosaur test

regenerate code

remove identity provider code in cluster managers

burn it
@SimonBaeumer SimonBaeumer force-pushed the sb/clean-up-standalone-provider branch from 5f1acdf to 8f0e24d Compare November 21, 2023 12:05
@SimonBaeumer SimonBaeumer merged commit 0bb2e48 into main Nov 21, 2023
6 checks passed
@SimonBaeumer SimonBaeumer deleted the sb/clean-up-standalone-provider branch November 21, 2023 13:15
johannes94 pushed a commit that referenced this pull request Jan 18, 2024
@SimonBaeumer
Remove fleetshard add-on and cleanup standalone provider (#1486)
c934da3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebensh ebensh ebensh approved these changes

Assignees

@ebensh ebensh

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonBaeumer @ebensh @openshift-merge-robot