Switch egress-proxy to a floating tag #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukletsov
requested review from
ebensh,
kovayur and
johannes94
as code owners
rukletsov
temporarily deployed
to
development
GitHub Actions
Inactive
rukletsov
temporarily deployed
to
development
GitHub Actions
Inactive
rukletsov
temporarily deployed
to
development
GitHub Actions
Inactive
stehessel
approved these changes
Nov 14, 2023
ludydoo
approved these changes
Nov 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ludydoo, rukletsov, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in #1411 we switched egress-proxy to a specific image to forcefully update all egress-proxy images on all data plane clusters. This has its own disadvantages, for instance, one needs to bump the image regularly.
This PR attempts a different strategy: floating image tag with "always" pull policy. While this does not guarantee that all deployments have the same image at a given point of time, we expect it to eventually update all egress-proxy images on, say, cluster upgrade events.
Checklist (Definition of Done)
Test manual
None, CI run and testing on stage.