Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-16643 Move infra-workloads to dedicated node pools #1460

Merged
merged 3 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@
"filename": "dp-terraform/helm/rhacs-terraform/charts/observability/templates/01-operator-06-cr.yaml",
"hashed_secret": "3e513f12b341ed3327bea645a728401b5d0f9ddb",
"is_verified": false,
"line_number": 15
"line_number": 21
}
],
"dp-terraform/helm/rhacs-terraform/charts/secured-cluster/init-bundle.yaml": [
Expand Down Expand Up @@ -564,5 +564,5 @@
}
]
},
"generated_at": "2023-11-06T14:09:00Z"
"generated_at": "2023-11-13T13:31:40Z"
}
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ spec:
values:
- {{ include "aggregator.fullname" . }}
topologyKey: topology.kubernetes.io/zone
{{- if .Values.tolerations }}
tolerations: {{- toYaml .Values.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector: {{- toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
terminationGracePeriodSeconds: 60
securityContext: {}
containers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,7 @@ customConfig:
secrets:
aws_region: "us-east-1"
aws_role_arn: ""

nodeSelector: {}

tolerations: []
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ spec:
labels:
app: cloudwatch-exporter
spec:
{{- if .Values.affinity }}
affinity: {{ toYaml .Values.affinity | indent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector: {{ toYaml .Values.nodeSelector | indent 8 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations: {{ toYaml .Values.tolerations | indent 8 }}
{{- end }}
containers:
- name: cloudwatch-exporter
image: {{ .Values.image | quote }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@ aws:
clusterName: ""
environment: ""
image: "ghcr.io/nerdswords/yet-another-cloudwatch-exporter:v0.55.0"

nodeSelector: {}

tolerations: []

affinity: {}
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,14 @@ spec:
managementState: "Managed"
collection:
logs:
{{- if .Values.tolerations }}
tolerations: {{ toYaml .Values.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector: {{ toYaml .Values.nodeSelector | nindent 8 }}
{{- end }}
{{- if .Values.resources }}
resources: {{ toYaml .Values.resources | nindent 8 }}
{{- end }}
type: "fluentd"
fluentd: {}
6 changes: 6 additions & 0 deletions dp-terraform/helm/rhacs-terraform/charts/logging/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ aws:
region: "us-east-1"
accessKeyId: ""
secretAccessKey: ""

nodeSelector: {}

tolerations: []

affinity: {}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ metadata:
name: observability-stack
namespace: {{ include "observability.namespace" . }}
spec:
{{- if .Values.affinity }}
affinity: {{ .Values.affinity | toYaml | nindent 4 }}
{{- end }}
{{- if .Values.tolerations }}
tolerations: {{ .Values.tolerations | toYaml | nindent 4 }}
{{- end }}
# The cluster ID is added as a label to all metrics when interacting with external services.
clusterId: {{ .Values.clusterName | quote }}
configurationSelector:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,9 @@ alertManager:
memory: 256Mi
limits:
memory: 256Mi

affinity: {}

tolerations: []

# observability operator doesn't expose nodeSelector
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,52 @@ spec:
clusterName: {{ required "clusterName is required when secured-cluster is enabled" .Values.clusterName }}
centralEndpoint: {{ required "centralEndpoint is required when secured-cluster is enabled" .Values.centralEndpoint }}
admissionControl:
resources:
requests:
memory: 100Mi
cpu: 100m
{{- if .Values.admissionControl.resources }}
resources: {{ toYaml .Values.admissionControl.resources | nindent 6 }}
{{- end }}
{{- if .Values.admissionControl.tolerations }}
tolerations: {{ toYaml .Values.admissionControl.tolerations | nindent 6 }}
{{- end }}
{{- if .Values.admissionControl.nodeSelector }}
nodeSelector: {{ toYaml .Values.admissionControl.nodeSelector | nindent 6 }}
{{- end }}
sensor:
resources:
requests:
memory: 100Mi
cpu: 100m
{{- if .Values.sensor.resources }}
resources: {{ toYaml .Values.sensor.resources | nindent 6 }}
{{- end }}
{{- if .Values.sensor.tolerations }}
tolerations: {{ toYaml .Values.sensor.tolerations | nindent 6 }}
{{- end }}
{{- if .Values.sensor.nodeSelector }}
nodeSelector: {{ toYaml .Values.sensor.nodeSelector | nindent 6 }}
{{- end }}
perNode:
collector:
resources:
requests:
memory: 100Mi
cpu: 100m
{{- if .Values.collector.resources }}
resources: {{ toYaml .Values.collector.resources | nindent 8 }}
{{- end }}
compliance:
resources:
requests:
memory: 100Mi
cpu: 100m
{{- if .Values.compliance.resources }}
resources: {{ toYaml .Values.compliance.resources | nindent 8 }}
{{- end }}
scanner:
analyzer:
{{- if .Values.scanner.analyzer.resources }}
resources: {{ toYaml .Values.scanner.analyzer.resources | nindent 8 }}
{{- end }}
{{- if .Values.scanner.analyzer.tolerations }}
tolerations: {{ toYaml .Values.scanner.analyzer.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.scanner.analyzer.nodeSelector }}
nodeSelector: {{ toYaml .Values.scanner.analyzer.nodeSelector | nindent 8 }}
{{- end }}
db:
{{- if .Values.scanner.analyzer.db.resources }}
resources: {{ toYaml .Values.scanner.analyzer.db.resources | nindent 10 }}
{{- end }}
{{- if .Values.scanner.analyzer.db.tolerations }}
tolerations: {{ toYaml .Values.scanner.analyzer.db.tolerations | nindent 10 }}
{{- end }}
{{- if .Values.scanner.analyzer.db.nodeSelector }}
nodeSelector: {{ toYaml .Values.scanner.analyzer.db.nodeSelector | nindent 10 }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,49 @@ admissionControl:
serviceTLS:
cert: ""
key: ""
resources:
requests:
memory: 100Mi
cpu: 100m
tolerations: []
nodeSelector: {}
ca:
cert: ""
collector:
serviceTLS:
cert: ""
key: ""
resources:
requests:
memory: 50Mi
cpu: 10m
compliance:
resources:
requests:
memory: 100Mi
cpu: 100m
scanner:
analyzer:
tolerations: []
nodeSelector: {}
resources:
requests:
memory: 100Mi
cpu: 100m
db:
tolerations: []
nodeSelector: {}
resources:
requests:
memory: 100Mi
cpu: 100m
sensor:
serviceTLS:
cert: ""
key: ""
resources:
requests:
memory: 100Mi
cpu: 10m
tolerations: []
nodeSelector: {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ spec:
labels:
app: fleetshard-sync
spec:
{{- if .Values.fleetshardSync.affinity }}
affinity: {{ toYaml .Values.fleetshardSync.affinity | nindent 8 }}
{{- end }}
{{- if .Values.fleetshardSync.tolerations }}
tolerations: {{ toYaml .Values.fleetshardSync.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.fleetshardSync.nodeSelector }}
nodeSelector: {{ toYaml .Values.fleetshardSync.nodeSelector | nindent 8 }}
{{- end }}
serviceAccountName: fleetshard-sync
containers:
- name: fleetshard-sync
Expand Down
69 changes: 69 additions & 0 deletions dp-terraform/helm/rhacs-terraform/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ fleetshardSync:
enabled: false
targetedOperatorUpgrades:
enabled: false
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule

acsOperator:
enabled: false
channel: latest
Expand All @@ -72,10 +79,27 @@ cloudwatch:
secretAccessKey: ""
clusterName: ""
environment: ""
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""

# See available parameters in charts/observability/values.yaml
# - enabled flag is used to completely enable/disable observability sub-chart
observability:
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
enabled: true
clusterName: ""
github:
Expand All @@ -98,6 +122,12 @@ logging:
aws:
accessKeyId: ""
secretAccessKey: ""
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""

# See available parameters in charts/audit-logs/values.yaml
# - enabled flag is used to completely enable/disable logging sub-chart
Expand All @@ -106,6 +136,12 @@ audit-logs:
image: 'registry.redhat.io/openshift-logging/vector-rhel8:v0.21'
annotations: {}
replicas: 3
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""
persistence:
enabled: true
storageClassName: ""
Expand Down Expand Up @@ -157,6 +193,12 @@ secured-cluster:
serviceTLS:
cert: ""
key: ""
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""
ca:
cert: ""
collector:
Expand All @@ -167,6 +209,27 @@ secured-cluster:
serviceTLS:
cert: ""
key: ""
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""
scanner:
analyzer:
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""
db:
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""

external-secrets:
fullnameOverride: rhacs-external-secrets
Expand All @@ -188,6 +251,12 @@ external-secrets:
image:
repository: quay.io/app-sre/external-secrets
tag: v0.9.5
tolerations:
- key: node-role.kubernetes.io/acscs-infra
operator: Exists
effect: NoSchedule
nodeSelector:
node-role.kubernetes.io/acscs-infra: ""

secretStore:
aws:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ spec:
app: rhacs-operator
control-plane: controller-manager
spec:
{{- if .affinity }}
affinity: {{ .affinity | toYaml | nindent 8 }}
{{- end }}
{{- if .nodeSelector }}
nodeSelector: {{ .nodeSelector | toYaml | nindent 8 }}
{{- end }}
{{- if .tolerations }}
tolerations: {{ .tolerations | toYaml | nindent 8 }}
{{- end }}
containers:
- args:
- --secure-listen-address=0.0.0.0:8443
Expand Down
Loading