Add helm dependencies to Dockerfile #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fleetshard operator lacks external secrets dependency in the image. The following changes have been added:
securityContext.runAsUser
from the subchart. External secrets operator sets user id as 1000 by default which is prohibited by openshift (without extra scc config). If you delete the key then openshift assigns a user id from a range, so from security perspective it should be better. The null value I set forsecurityContext.runAsUser
in rootvalues.yaml
works in helm but not in the operator. Most likely because the older version of helm is used in operator-sdk. I submitted a bug report to operator sdk and made a workaround to remove the default key(s) from the dependency.Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts