-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-20795: probe telemetry configuration #1455
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0x656b694d, kurlov, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In the context of cloud services, we want to have Telemetry always configured, except for the internal instances, such as probes.
Therefore, the proposed change sets the TelemetryEnabled property to true (which essentially enables telemetry configuration), and disables telemetry collection by setting "DISABLED" value for the key.
Checklist (Definition of Done)
Test manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
CI, unit tests.