Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-20795: probe telemetry configuration #1455

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

parametalol
Copy link
Contributor

@parametalol parametalol commented Nov 10, 2023

Description

In the context of cloud services, we want to have Telemetry always configured, except for the internal instances, such as probes.
Therefore, the proposed change sets the TelemetryEnabled property to true (which essentially enables telemetry configuration), and disables telemetry collection by setting "DISABLED" value for the key.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI, unit tests.

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@parametalol parametalol requested a review from kurlov November 10, 2023 14:59
@parametalol parametalol changed the title fix: probe telemetry configuration ROX-20795: probe telemetry configuration Nov 10, 2023
@parametalol parametalol marked this pull request as ready for review November 10, 2023 15:03
Copy link
Contributor

openshift-ci bot commented Nov 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0x656b694d, kurlov, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@parametalol parametalol merged commit d1a0d59 into main Nov 14, 2023
9 checks passed
@parametalol parametalol deleted the michael/fix-probe-telemetry-config branch November 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants