Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-20694: Use app-interface image tag pattern for all the images #1452

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Nov 8, 2023

Description

This change reduces the number of docker tag patterns in the project to one, namely the one required by the app-interface.
Before this change, make tag returned a tag in stackrox format (i.e 2023-09-26.1-103-gc66102d1fc). We don't use this format anywhere but E2E tests and we have to override it everywhere.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

Local deploy.

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 0a4399f into main Nov 8, 2023
5 checks passed
@kovayur kovayur deleted the yury/ROX-20694-make-tag branch November 8, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants