Add pprof server to fleet-manager and unlimited evals in testing&develop

[SimonBaeumer]

Description

• Add pprof server to fleet-manager on port 6060
• Add name parameter to create-central.sh
• Allow more instance for eval instances in development
• Increase data-plane capacity in development

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary
• RDS changes were e2e tested manually
• Check AWS limits are reasonable for changes provisioning new resources

Test manual

• /

[ludydoo]

This import should be in the block below no?

[SimonBaeumer]

Sí, done

[ludydoo]

Why not use the listener here for the pprof server ?

[SimonBaeumer]

Because Listen-func is used only for Listen and not for starting the server. Only the API Server uses the Listen function.

See docs here on the funs for more info:

acs-fleet-manager/pkg/server/api_server.go

Lines 158 to 187 in ac4af15

	// Listen only starts the listener, not the server.
	// Useful for breaking up ListenAndServer (Start) when you require the server to be listening before continuing
	func (s *APIServer) Listen() (listener net.Listener, err error) {
	l, err := net.Listen("tcp", s.serverConfig.BindAddress)
	if err != nil {
	return l, fmt.Errorf("starting the listener: %w", err)
	}
	return l, nil
	}
	// Start ...
	func (s *APIServer) Start() {
	go s.Run()
	}
	// Run Start listening on the configured port and start the server. This is a convenience wrapper for Listen() and Serve(listener Listener)
	func (s *APIServer) Run() {
	listener, err := s.Listen()
	if err != nil {
	glog.Fatalf("Unable to start API server: %s", err)
	}
	// Before we start processing requests, wait
	// for the server to be ready to run.
	for _, condition := range s.readyConditions {
	condition.Wait()
	}
	s.Serve(listener)
	}

[ludydoo]

I'm not sure about creating a service for it. Because fleet-manager runs with multiple replicas, we never know which one we hit. We should just do a port forward and use that rather than creating a service for it ?

[SimonBaeumer]

Good catch, removed it!

[kovayur]

Looks good, I echo Ludovic's review

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SimonBaeumer,ludydoo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment