Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove imagepulldockerconfigfile parameter #1427

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Nov 1, 2023

Description

Cleanup fleet-manager by removing the unused parameter

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI

@kovayur kovayur requested a review from SimonBaeumer November 1, 2023 12:23
@kovayur kovayur temporarily deployed to development November 1, 2023 12:23 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:23 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:23 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the approved label Nov 1, 2023
@kovayur kovayur temporarily deployed to development November 1, 2023 12:43 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:43 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:43 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:47 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:47 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:47 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:56 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:56 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development November 1, 2023 12:56 — with GitHub Actions Inactive
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kovayur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 3418a46 into main Nov 2, 2023
5 checks passed
@kovayur kovayur deleted the yury/remove-imagepulldockerconfigfile branch November 2, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants