Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19589: Use a context with deadline for initialization. #1348

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Oct 12, 2023

Description

The primary motivation is to prevent fleetshard from getting stuck indefinitely on startup in case of transient network issues. ROX-19589 contains more background.

Note that the first time this change was merged (#1229) it caused the probe to break, even though e2e test passed. The cause is not well understood, but this time I took a detailed look into how the {{ctx}} passed into each New*Auth function is used. I found a single child call which saved it for subsequent use after the current function exits, so I passed a background context there.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

There isn't much we can test manually here outside of CI. This time we're better prepared for any unexpected side-effects:

@porridge porridge temporarily deployed to development October 12, 2023 08:29 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development October 12, 2023 08:29 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development October 12, 2023 08:29 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@porridge porridge merged commit cf837b3 into main Oct 16, 2023
@porridge porridge deleted the porridge/propagate-context branch October 16, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants