ROX-19589: Use a context with deadline for initialization. #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary motivation is to prevent fleetshard from getting stuck indefinitely on startup in case of transient network issues. ROX-19589 contains more background.
Note that the first time this change was merged (#1229) it caused the probe to break, even though e2e test passed. The cause is not well understood, but this time I took a detailed look into how the {{ctx}} passed into each
New*Auth
function is used. I found a single child call which saved it for subsequent use after the current function exits, so I passed a background context there.Checklist (Definition of Done)
Unit and integration tests addedTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
There isn't much we can test manually here outside of CI. This time we're better prepared for any unexpected side-effects: