-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ForceReconcile, add unit and e2e tests #1338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
I find it confusing that the API has both camel and snake case json fields! (e.g. centralDataURL
and instance_type
).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Absolutely, but it is this way to stick to the naming convention of the fleet-manager template that introduced the inconsistency. |
Description
This PR fixes a bug with strategic patch for the endpoint.
PATCH /api/rhacs/v1/admin/central/$tenant_id
. ForceReconcile in the database would never be set because it is deleted from the map used to merge the original requests values with the patch values.Also adds an E2E test to make sure force_reconcile can always be set via API because it is required for a lot of SOPs to work properly.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
only CI/local unit test