Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18908: Hook up integration to dogfood central. #1316

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Oct 4, 2023

Description

I copied an init bundle from stage to integration secrets manager using:

$ aws-login-stg
$ AWS_REGION=us-east-1 chamber export -b secretsmanager secured-cluster |jq .
$ aws-login-int
$ AWS_REGION=us-east-1 chamber import -b secretsmanager secured-cluster -
# paste the output from above omitting the "_chamber_metadata" piece
$

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

N/A

@porridge porridge requested a review from kurlov October 4, 2023 11:55
@porridge porridge temporarily deployed to development October 4, 2023 11:55 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development October 4, 2023 11:55 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the approved label Oct 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@porridge porridge merged commit 986d445 into main Oct 5, 2023
4 checks passed
@porridge porridge deleted the porridge/ROX-18908-enable-sc-int branch October 5, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants