ROX-19811: Set label selector to dogfooding secured cluster CR #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurlov
requested review from
ebensh,
kovayur,
johannes94 and
GrimmiMeloni
as code owners
SimonBaeumer
approved these changes
Sep 28, 2023
ludydoo
reviewed
Sep 28, 2023
| @@ -3,6 +3,8 @@ kind: SecuredCluster | |||
| metadata: | |||
| name: stackrox-secured-cluster-services | |||
| namespace: {{ include "secured-cluster.namespace" . }} | |||
| labels: | |||
| rhacs.redhat.com/selector: dogfooding | |||
There was a problem hiding this comment.
Could you add a comment specifying what this is for? So that other engs are aware etc.
ludydoo
approved these changes
Sep 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, ludydoo, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
kurlov
deleted the
akurlov/ROX-19811-set_label_selector_to_dogfooding_cr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set label selector value to Dogfooding secured cluster CR. It's necessary to specify which operator should reconcile the instance
Checklist (Definition of Done)
- [ ] Unit and integration tests added- [ ] Added test description underTest manual- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.- [ ] Add secret to app-interface Vault or Secrets Manager if necessary- [ ] RDS changes were e2e tested manually- [ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual
N/A