Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19735 - add operator configs to gitops #1278

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

SimonBaeumer
Copy link
Member

@SimonBaeumer SimonBaeumer commented Sep 18, 2023

Description

Add the operator to the gitops configuration.

  • Change return value from operator.Validate to field.ErrorList for extendability and compatibility with gitops.Validate.
  • Add test scenario to validate the operator configuration with Central configs

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • [] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...

Test manual

  • Unit tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@SimonBaeumer SimonBaeumer temporarily deployed to development September 18, 2023 13:13 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 18, 2023 13:13 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 18, 2023 13:13 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer changed the base branch from main to sb/use-errors September 18, 2023 13:16
Base automatically changed from sb/use-errors to main September 19, 2023 07:51
@SimonBaeumer SimonBaeumer force-pushed the sb/rox-19735-add-operator-to-gitops branch from 4e7d6c1 to aec2f62 Compare September 19, 2023 12:18
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 12:18 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 12:18 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 12:18 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 12:55 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 12:55 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 12:55 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer marked this pull request as ready for review September 19, 2023 13:08
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 13:08 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 13:08 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 13:08 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer changed the title ROX-19735 add operator to gitops ROX-19735 - add operator configs to gitops Sep 19, 2023
Copy link
Collaborator

@ludydoo ludydoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Consider moving the operator gitops configs to the gitops package

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
Copy link
Member

@kurlov kurlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, ludydoo, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

New changes are detected. LGTM label has been removed.

@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 13:20 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 13:20 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 19, 2023 13:20 — with GitHub Actions Inactive
@SimonBaeumer
Copy link
Member Author

/retest

@SimonBaeumer SimonBaeumer temporarily deployed to development September 21, 2023 08:33 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 21, 2023 08:33 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 21, 2023 08:33 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer merged commit 1257314 into main Sep 21, 2023
@SimonBaeumer SimonBaeumer deleted the sb/rox-19735-add-operator-to-gitops branch September 21, 2023 09:42
kovayur added a commit that referenced this pull request Sep 26, 2023
* Use Openshift golang-1.20 builder image (#1275)

* Add kind cluster type (#1256)

* Refactor operator config to use field.Error (#1276)

* fix typo causing skip of DNS creation on restore (#1277)

* ROX-19718: Add flag for fleetmanager gitops (#1283)

* Specify reconcile interval in workers (#1265)

* Add request body to rotate-secrets endpoint (#1272)

* Disable automounting for egress proxy (#1286)

* ROX-19808: Remove GitOps admin handler (#1290)

Remove GitOps admin handler

* ROX-19692: Add a release preparation workflow. (#1284)

Prepare release workflow.

* ROX-19735 - add operator configs to gitops (#1278)

* ROX-19692: New workflow to auto-create production merge PRs. (#1291)

New workflow to auto-create production merge PRs.

* ROX-19810: Bump controller-runtime and stackrox deps (#1292)

* Bump controller-runtime and stackrox deps

* Bump openshift/api

* Call /current_account before reserving quota (#1289)

* Remove multi target build (#1259)

* fixed restore endpoint (#1298)

* ROX-19281: Fix nil pointer dereference in E2E tests when Central is not ready (#1216)

* Rename ACSMS -> ACSCS in dev scripts (#1252)

* Log result of current_account call execution (#1297)

* Cleanup errors.go (#1299)

---------

Co-authored-by: Vlad Bologa <[email protected]>
Co-authored-by: Simon Bäumer <[email protected]>
Co-authored-by: Johannes Malsam <[email protected]>
Co-authored-by: Ludovic Cleroux <[email protected]>
Co-authored-by: Ivan Degtiarenko <[email protected]>
Co-authored-by: Alex Rukletsov <[email protected]>
Co-authored-by: Marcin Owsiany <[email protected]>
Co-authored-by: Aleksandr Kurlov <[email protected]>
Co-authored-by: Yury Kovalev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants