Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build scripts to remove duplicated code #1262

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

SimonBaeumer
Copy link
Member

@SimonBaeumer SimonBaeumer commented Sep 14, 2023

Description

Refactor build scripts to remove duplicated code.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

  • Execute build scripts

@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:02 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:02 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:02 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:06 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:06 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:06 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer requested a review from kurlov September 14, 2023 08:06
@SimonBaeumer SimonBaeumer changed the base branch from main to sb/add-ci-fleet-manager-image September 14, 2023 08:07
@SimonBaeumer SimonBaeumer mentioned this pull request Sep 14, 2023
9 tasks
Base automatically changed from sb/add-ci-fleet-manager-image to main September 14, 2023 08:31
@SimonBaeumer SimonBaeumer force-pushed the sb/refactor-build-scripts branch from 64f31a4 to c800e13 Compare September 14, 2023 08:48
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:48 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:48 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 08:48 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:25 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:25 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:25 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:29 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:29 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:29 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:49 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:49 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development September 14, 2023 09:49 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer merged commit 0cf5133 into main Sep 14, 2023
@SimonBaeumer SimonBaeumer deleted the sb/refactor-build-scripts branch September 14, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants