ROX-19694: Run CI and build/push probe on stage branch. #1260
Conversation
porridge
temporarily deployed
to
development
GitHub Actions
Inactive
porridge
temporarily deployed
to
development
GitHub Actions
Inactive
porridge
temporarily deployed
to
development
GitHub Actions
Inactive
| @@ -4,6 +4,7 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - stage | |||
There was a problem hiding this comment.
I don't know why we rebuild our probe on pushes to stage - is the intention that we test changes to the probe as well? And given the last step of build and pushing the probe, wouldn't these changes clobber each other in practice?
There was a problem hiding this comment.
The intention is to run probe in stage.
We deploy all images from an image named the same as the commit we're pushing.
So if we even push to stage a commit that's not in main -> 💥
There was a problem hiding this comment.
And yes, a push of the same image tag would overwrite I think, unless there is an explicit check for this in the script. Either way this is already happening for main vs production branch in the jenkins job.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: porridge, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
See title.
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
N/A