Fix reconcile loop break when central is not changed #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes94
approved these changes
Sep 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, mtodor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtodor
deleted the
mtodor/fix-reconcile-loop-no-central-change-break
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After investigation about problem-related to the increase of requests made to fleet-manager. I found that we are making way more reconciliation.
Before, we had 1 in 24h, and after some changes, we started having 2000 in 24h. That was reflected in the increased number of requests for fleet-manager.
After investigating logging and code, I found that the potential problem is caused by sorting a list of secrets before hashing. We would store the hash in reverse order and compare it with the hash created in sorted order.
That made diff between hashes and reconciliation was triggered more often.
Commit only with added test:
https://github.com/stackrox/acs-fleet-manager/actions/runs/6146719440/job/16676645194
Checklist (Definition of Done)
Test manual[ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)[ ] Add the ticket number to the PR title if available, i.e.ROX-12345: ...[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.[ ] Add secret to app-interface Vault or Secrets Manager if necessary[ ] RDS changes were e2e tested manually[ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual