Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19228: ACS CS connection string updates for 4.2 #1249

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Sep 8, 2023

Description

Due to changes in ACS 4.2, some changes to the Central DB connection string in ACS CS are required.

The new connection strings should be backwards compatible with older ACS versions (ACS CS is currently running v4.1.3).

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

Tested RDS changes E2E - with both ACS v4.1 and v4.2.

Connection string from Central logs:

Migrator: 2023/09/08 16:25:35.546389 log.go:18: Info: connect to gorm: "host=rhacs-cjtkg9j3d8v001se2n8g-db-cluster.cluster-cz7zwsnynmtn.us-east-1.rds.amazonaws.com port=5432 user=rhacs_central dbname=central_active statement_timeout=1200000 client_encoding=UTF8 sslmode=verify-full sslrootcert=/usr/local/share/ca-certificates/00-rds-ca-bundle.crt pool_min_conns=10 pool_max_conns=90"
# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@vladbologa vladbologa temporarily deployed to development September 8, 2023 16:05 — with GitHub Actions Inactive
@vladbologa vladbologa temporarily deployed to development September 8, 2023 16:05 — with GitHub Actions Inactive
@vladbologa vladbologa temporarily deployed to development September 8, 2023 16:05 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the approved label Sep 8, 2023
Copy link

@dashrews78 dashrews78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me. Thanks

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashrews78, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladbologa vladbologa merged commit f35e8b2 into main Sep 8, 2023
@vladbologa vladbologa deleted the vbologa/connection_string branch September 8, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants