-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AMS error experience #1247
Conversation
pkg/errors/errors.go
Outdated
@@ -770,8 +770,8 @@ func FailedClusterAuthorization(err error) *ServiceError { | |||
reason := "failed to reserve quota" | |||
// Visiting the OpenShift page in console registers the user and their organisation with OCM. | |||
// See https://issues.redhat.com/browse/SDB-3194 for more context. | |||
if svcErr.Is404() { | |||
reason += " - visit https://console.redhat.com/openshift and try again" | |||
if svcErr.Is404() || svcErr.IsForbidden() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know visiting https://console.redhat.com/openshift
does not help when AMS returns 403
. So I'd split this off from the 404
case and maybe condense the error message a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It would be good to apply the suggestion from @stehessel before merging.
Co-authored-by: Stephan Hesselmann <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivan-degtiarenko, mtodor, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Broaden amount of error codes that return an extended error message + give customer alternative if going to
/openshift
URL does not workChecklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts