Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-19494: Increase timeout and improve debugability of e2e test. #1244

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Sep 7, 2023

Description

See ticket for timeouts we're seeing from time to time. This bumps the timeout a little and provides better/more log messages to be able to debug this better in the future should the bump prove insufficient.

FTR, this is the "safe" part of #1229 that does not include the context propagation changes, which proved problematic.

@vladbologa please kindly verify that the date command works as expected on a mac.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI should be sufficient.

@porridge porridge requested a review from vladbologa September 7, 2023 11:22
@porridge porridge temporarily deployed to development September 7, 2023 11:22 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 7, 2023 11:23 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development September 7, 2023 11:23 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the approved label Sep 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: porridge, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [porridge,vladbologa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@porridge porridge merged commit f4133e0 into main Sep 11, 2023
@porridge porridge deleted the porridge/timeout-debug branch September 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants