Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix probe log when response if empty #1235

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

stehessel
Copy link
Contributor

@stehessel stehessel commented Sep 4, 2023

Description

Prevent the () in log when the Central response is empty.

E0904 10:29:57.650706 1 probe.go:103] could not list centrals: : Get "https://api.integration.openshift.com/api/rhacs/v1/centrals": context deadline exceeded
W0904 10:29:57.650759 1 runtime.go:44] cleanup failed: cleanup centrals failed: retry failed: context deadline exceeded: probe run failed: creation of central instance failed: parsing HTTP response: undefined response type
I0904 10:29:57.650781 1 probe.go:69] probe run has been started: fleetManagerEndpoint="https://api.integration.openshift.com/", provider="aws", region="us-east-1"
I0904 10:29:57.661891 1 probe.go:147] creation of central instance () requested
I0904 10:29:57.661931 1 probe.go:54] elapsed time: 11.143458ms
I0904 10:29:57.661946 1 probe.go:79] probe run has ended

Compared to healthy one:

I0904 09:49:37.082595 1 probe.go:127] finished clean up attempt of probe resources
I0904 09:49:37.082638 1 probe.go:69] probe run has been started: fleetManagerEndpoint="https://api.stage.openshift.com/", provider="aws", region="us-east-1"
I0904 09:49:37.331281 1 probe.go:147] creation of central instance (cjqqgcdib723trpqgtag) requested
I0904 10:01:07.349105 1 probe.go:212] central instance cjqqgcdib723trpqgtag is in "ready" state
I0904 10:01:12.430202 1 probe.go:176] deletion of central instance cjqqgcdib723trpqgtag requested
I0904 10:02:02.438883 1 probe.go:235] central instance cjqqgcdib723trpqgtag has been deleted
I0904 10:02:02.438911 1 probe.go:54] elapsed time: 12m25.356266322s
I0904 10:02:02.438923 1 probe.go:86] probe run has ended

Also added a dedicated log statement when the probe fails, so we don't have to wait until the cleanup is done (which may also fail and retry).

@stehessel stehessel temporarily deployed to development September 4, 2023 10:54 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 4, 2023 10:54 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 4, 2023 10:54 — with GitHub Actions Inactive
@stehessel stehessel force-pushed the fix-probe-log-empty-response branch from 29c35ee to 47cc2be Compare September 4, 2023 11:23
@stehessel stehessel temporarily deployed to development September 4, 2023 11:23 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 4, 2023 11:23 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 4, 2023 11:23 — with GitHub Actions Inactive
@stehessel stehessel force-pushed the fix-probe-log-empty-response branch from 47cc2be to 8b2649f Compare September 4, 2023 11:24
@stehessel stehessel temporarily deployed to development September 4, 2023 11:25 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 4, 2023 11:25 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development September 4, 2023 11:25 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: porridge, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2023
@stehessel stehessel merged commit e0983d5 into main Sep 4, 2023
@stehessel stehessel deleted the fix-probe-log-empty-response branch September 4, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants