-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-16090: Support integration in a couple more places #1215
Conversation
f35e060
to
6a74726
Compare
@porridge: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The e2e failure seems unrelated, filed https://issues.redhat.com/browse/ROX-19281 to track:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, kovayur, porridge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e |
For the sake of velocity, I'm going to force-merge since the e2e test cannot possibly be related (:crossed_fingers:). |
Description
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
CI should cover the parts that can be tested.