Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-16090: Support integration in a couple more places #1215

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Aug 24, 2023

Description

  • Allow the special case of int==integration.
  • Teach probe deploy script about integration env.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI should cover the parts that can be tested.

@porridge porridge temporarily deployed to development August 24, 2023 05:36 — with GitHub Actions Inactive
@porridge porridge force-pushed the porridge/int-special-case branch from f35e060 to 6a74726 Compare August 24, 2023 05:38
@porridge porridge temporarily deployed to development August 24, 2023 05:38 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development August 24, 2023 05:38 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development August 24, 2023 05:38 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

@porridge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 6a74726 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@porridge
Copy link
Collaborator Author

porridge commented Aug 24, 2023

The e2e failure seems unrelated, filed https://issues.redhat.com/browse/ROX-19281 to track:

------------------------------
Central should be deployed and can be force-deleted can be cleaned up manually
/src/e2e/e2e_test.go:567
  Current time: 2023-08-24 06:09:11.668046778 +0000 UTC m=+949.585964904
  Central name: e2e-f53c88d363041607
  Central ID: cjjf5mqc4uq9aepv286g
• [0.050 seconds]
------------------------------
Central should be deployed and can be force-deleted should delete external DNS entries
/src/e2e/e2e_test.go:591
  Current time: 2023-08-24 06:09:11.718262602 +0000 UTC m=+949.636180728
  Central name: e2e-f53c88d363041607
  Central ID: cjjf5mqc4uq9aepv286g
  [PANICKED] in [It] - /usr/local/go/src/runtime/panic.go:260 @ 08/24/23 06:09:11.938
• [PANICKED] [0.220 seconds]
Central should be deployed and can be force-deleted [It] should delete external DNS entries
/src/e2e/e2e_test.go:591
  [PANICKED] Test Panicked
  In [It] at: /usr/local/go/src/runtime/panic.go:260 @ 08/24/23 06:09:11.938
  runtime error: invalid memory address or nil pointer dereference
  Full Stack Trace
    github.com/stackrox/acs-fleet-manager/e2e/dns.getHostedZone(0x1?, 0x0)
    	/src/e2e/dns/records_loader.go:80 +0x230
    github.com/stackrox/acs-fleet-manager/e2e/dns.NewRecordsLoader(0xc000f0e098, 0x4ac2d9?)
    	/src/e2e/dns/records_loader.go:26 +0x57
    github.com/stackrox/acs-fleet-manager/e2e.glob..func4.4.5()
    	/src/e2e/e2e_test.go:599 +0xd7
------------------------------

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kovayur, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ebensh,kovayur,porridge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@porridge
Copy link
Collaborator Author

/test e2e

@porridge
Copy link
Collaborator Author

porridge commented Aug 24, 2023

For the sake of velocity, I'm going to force-merge since the e2e test cannot possibly be related (:crossed_fingers:).

@porridge porridge merged commit 7783104 into main Aug 24, 2023
@porridge porridge deleted the porridge/int-special-case branch August 24, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants