Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fleetshard): set Central PVC annotation only if managedDB=true #1213

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

stehessel
Copy link
Contributor

Description

For dev deployments we often deploy fleetshard-sync without managed DB integration. In these cases, we still need the Central PVC. Hence, only set the obsolete PVC annotation if managedDB=true.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stehessel stehessel temporarily deployed to development August 22, 2023 10:41 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 22, 2023 10:41 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 22, 2023 10:41 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel marked this pull request as ready for review August 22, 2023 10:43
@stehessel stehessel temporarily deployed to development August 22, 2023 10:43 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 22, 2023 10:44 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 22, 2023 10:44 — with GitHub Actions Inactive
@stehessel stehessel force-pushed the set-pvc-annotation-based-on-managedDB branch from 3b1be65 to 4d157ea Compare August 22, 2023 10:48
@openshift-ci openshift-ci bot removed the lgtm label Aug 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

New changes are detected. LGTM label has been removed.

@stehessel stehessel temporarily deployed to development August 22, 2023 10:48 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 22, 2023 10:48 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 22, 2023 10:48 — with GitHub Actions Inactive
@stehessel stehessel merged commit deb10a6 into main Aug 22, 2023
@stehessel stehessel deleted the set-pvc-annotation-based-on-managedDB branch August 22, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants