Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fleetshard): use FQDN for k8s svc #1208

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix(fleetshard): use FQDN for k8s svc #1208

merged 1 commit into from
Aug 21, 2023

Conversation

stehessel
Copy link
Contributor

Description

Use the FQDN to prevent unnecessary DNS lookups and to make sure that the no_proxy env var is set correctly with protocol prefix.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

Tested on OpenShift cluster.

@stehessel stehessel requested a review from dhaus67 August 21, 2023 12:52
@stehessel stehessel temporarily deployed to development August 21, 2023 12:53 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 21, 2023 12:53 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development August 21, 2023 12:53 — with GitHub Actions Inactive
@stehessel
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-degtiarenko, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel merged commit 4908a2a into main Aug 21, 2023
@stehessel stehessel deleted the use-fqdn-k8s-svc branch August 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants