Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing labels to group by #1203

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Changing labels to group by #1203

merged 1 commit into from
Aug 14, 2023

Conversation

kylape
Copy link
Contributor

@kylape kylape commented Aug 14, 2023

  • rhacs_instance_id -> namespace: not all alerts have rhacs_instance_id
  • add severity: don't want to group alerts with different severities together

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

* rhacs_instance_id -> namespace: not all alerts have rhacs_instance_id
* add severity: don't want to group alerts with different severities together
@kylape kylape temporarily deployed to development August 14, 2023 17:09 — with GitHub Actions Inactive
@kylape kylape temporarily deployed to development August 14, 2023 17:09 — with GitHub Actions Inactive
@kylape kylape requested a review from stehessel August 14, 2023 17:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kylape, stehessel
Once this PR has been reviewed and has the lgtm label, please assign ivan-degtiarenko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kylape kylape merged commit 8a0aaf0 into main Aug 14, 2023
@kylape kylape deleted the klape/pd-alert-grouping-2 branch August 14, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants