Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s API to NO_PROXY configuration #1200

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

ivan-degtiarenko
Copy link
Contributor

Description

Diagnostic bundle functionality within central requires access to k8s API to obtain diagnostic data about central cluster.
This PR aims to provide such access via NO_PROXY variable.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TBD

@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 14, 2023 06:33 — with GitHub Actions Inactive
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 14, 2023 06:33 — with GitHub Actions Inactive
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 14, 2023 06:33 — with GitHub Actions Inactive
@@ -268,7 +268,10 @@ func (r *CentralReconciler) getInstanceConfig(remoteCentral *private.ManagedCent
additionalNoProxyURL := url.URL{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename this to `auditLoggingURL?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-degtiarenko, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

New changes are detected. LGTM label has been removed.

@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 14, 2023 15:40 — with GitHub Actions Inactive
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 14, 2023 15:40 — with GitHub Actions Inactive
@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development August 14, 2023 15:40 — with GitHub Actions Inactive
@ivan-degtiarenko
Copy link
Contributor Author

/retest

@ivan-degtiarenko ivan-degtiarenko merged commit 32d4e33 into main Aug 15, 2023
@ivan-degtiarenko ivan-degtiarenko deleted the ivan/mark-kube-api-no-proxy branch August 15, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants