-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s API to NO_PROXY configuration #1200
Conversation
@@ -268,7 +268,10 @@ func (r *CentralReconciler) getInstanceConfig(remoteCentral *private.ManagedCent | |||
additionalNoProxyURL := url.URL{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename this to `auditLoggingURL?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivan-degtiarenko, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
/retest |
Description
Diagnostic bundle functionality within central requires access to k8s API to obtain diagnostic data about central cluster.
This PR aims to provide such access via
NO_PROXY
variable.Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TBD