Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18728: Add operator deployment cache #1179

Merged

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Jul 28, 2023

Description

Skip ACS Operator installation attempt if it's already attempted
Delete duplicate operator images

Checklist (Definition of Done)

- [ ] Unit and integration tests added

  • Added test description under Test manual
    - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
    - [ ] CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
    - [ ] Add secret to app-interface Vault or Secrets Manager if necessary
    - [ ] RDS changes were e2e tested manually
    - [ ] Check AWS limits are reasonable for changes provisioning new resources

Test manual

1. Prepare cluster for canary upgrade feature
scripts/install_operator_canary.sh

2. Create a new central instance
curl -XPOST --header "Authorization: Bearer $(ocm token)" 'http://localhost:7000/api/rhacs/v1/centrals?async=true' --data '{"region": "standalone", "cloud_provider": "standalone", "multi_az": true, "name": "testcache"}' | jq

3. Check Fleetshard-sync logs
k logs -f fleetshard-sync-57db87795f-pblbw -n acsms
....
I0804 15:06:16.408486       1 main.go:33] Starting application
I0804 15:06:16.408777       1 main.go:34] FleetManagerEndpoint: http://fleet-manager:8000
I0804 15:06:16.408881       1 main.go:35] ClusterID: 1234567890abcdef1234567890abcdef
I0804 15:06:16.408943       1 main.go:36] RuntimePollPeriod: 10s
I0804 15:06:16.409117       1 main.go:37] AuthType: RHSSO
I0804 15:06:16.409186       1 main.go:39] ManagedDB.Enabled: false
I0804 15:06:16.409269       1 main.go:40] ManagedDB.SecurityGroup: sg-09084991144b8d1fc
I0804 15:06:16.409418       1 main.go:41] ManagedDB.SubnetGroup: acs-dev-dp-01-database-vpc-private-subnet-group
I0804 15:06:17.204713       1 client.go:42] Connected to k8s cluster: https://10.43.0.1:443
I0804 15:06:18.065581       1 runtime.go:113] fleetshard runtime started
I0804 15:06:18.065861       1 runtime.go:114] Auth provider initialisation enabled: false
I0804 15:06:18.065914       1 runtime.go:299] OpenShift Routes available: true
E0804 15:06:18.275740       1 runtime.go:132] retrieving list of managed centrals: 401 Unauthorized
I0804 15:06:19.297058       1 runtime.go:276] Installing Operator version: 4.0.1
I0804 15:06:20.418246       1 logger.go:208] Received central count changed: received 1 centrals
I0804 15:06:20.420207       1 reconciler.go:127] Start reconcile central rhacs-cj6h12hsnsig01svr7i0/testcache
I0804 15:06:20.759968       1 reconciler.go:444] Central rhacs-cj6h12hsnsig01svr7i0/testcache is already up to date
I0804 15:06:30.609595       1 reconciler.go:127] Start reconcile central rhacs-cj6h12hsnsig01svr7i0/testcache
I0804 15:06:30.935064       1 reconciler.go:444] Central rhacs-cj6h12hsnsig01svr7i0/testcache is already up to date
....

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kurlov kurlov temporarily deployed to development July 28, 2023 21:36 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development July 28, 2023 21:36 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development July 28, 2023 21:36 — with GitHub Actions Inactive
@kurlov kurlov marked this pull request as ready for review August 4, 2023 15:18
@kurlov kurlov temporarily deployed to development August 4, 2023 15:18 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 4, 2023 15:18 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 4, 2023 15:18 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 4, 2023 15:19 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 4, 2023 15:19 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 4, 2023 15:19 — with GitHub Actions Inactive
@kurlov kurlov requested a review from ludydoo August 4, 2023 15:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

New changes are detected. LGTM label has been removed.

@kurlov kurlov temporarily deployed to development August 7, 2023 08:29 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 7, 2023 08:29 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development August 7, 2023 08:29 — with GitHub Actions Inactive
@kurlov kurlov merged commit 27b4340 into main Aug 7, 2023
@kurlov kurlov deleted the akurlov/ROX-18728-add_operator_deployment_configs_cache branch August 7, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants