Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probe): init probe metric gauges with zero value #1162

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

stehessel
Copy link
Contributor

Description

Initialize gauage metrics to avoid complications due to undefined gauge values. See stackrox/rhacs-observability-resources#115. The timestamps default to 0, which translates to 1970-01-01. It is defined such that any actual timestamp will be larger than this value.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@stehessel stehessel temporarily deployed to development July 17, 2023 21:13 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development July 17, 2023 21:13 — with GitHub Actions Inactive
@stehessel stehessel temporarily deployed to development July 17, 2023 21:13 — with GitHub Actions Inactive
@stehessel
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: janisz, stehessel
Once this PR has been reviewed and has the lgtm label, please assign johannes94 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stehessel stehessel merged commit 2c44cb2 into main Jul 18, 2023
@stehessel stehessel deleted the init-probe-gauge-metrics branch July 18, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants