Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-17723: Fix imagePullSecret value source #1152

Merged

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Jul 13, 2023

Description

This fix stage deployment

Checklist (Definition of Done)

- [ ] Unit and integration tests added

  • Added test description under Test manual
    - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
    - [ ] Add secret to app-interface Vault or Secrets Manager if necessary
    - [ ] RDS changes were e2e tested manually
    - [ ] Check AWS limits are reasonable for changes provisioning new resources

Test manual

HELM_DRY_RUN=true HELM_DEBUG=true AWS_SAML_ROLE=<stage user> ./terraform_cluster.sh stage <stage_cluster>

@kurlov kurlov temporarily deployed to development July 13, 2023 10:14 — with GitHub Actions Inactive
@kurlov kurlov temporarily deployed to development July 13, 2023 10:14 — with GitHub Actions Inactive
@kurlov kurlov requested review from kovayur and SimonBaeumer July 13, 2023 10:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit 05be2d2 into main Jul 13, 2023
@kurlov kurlov deleted the akurlov/ROX-17723_fix_image_pull_creds_template_source_value branch July 13, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants