Release cherry-pick: Disable dog-fooding in prod (#1141) #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable dogfooding in prod
kurlov
approved these changes
Jul 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vladbologa
changed the title
kovayur
pushed a commit
that referenced
this pull request
Jan 17, 2024
Disable dogfooding in prod ## Description <!-- Please include a summary of the change and a link to the JIRA ticket. Please add any additional motivation and context as needed. Screenshots are also welcome --> ## Checklist (Definition of Done) <!-- Please strikethrough options not relevant using two tildes ~~Text~~. Do not delete non relevant options --> - [ ] Unit and integration tests added - [ ] Added test description under `Test manual` - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...) - [ ] CI and all relevant tests are passing - [ ] Add the ticket number to the PR title if available, i.e. `ROX-12345: ...` - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel. - [ ] Add secret to app-interface Vault or Secrets Manager if necessary - [ ] RDS changes were e2e tested [manually](../docs/development/howto-e2e-test-rds.md) - [ ] Check AWS limits are reasonable for changes provisioning new resources ## Test manual **TODO:** Add manual testing efforts ``` # To run tests locally run: make db/teardown db/setup db/migrate make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development make verify lint binary test test/integration ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable dogfooding in prod
Description
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts