Fix operator RBAC rules #1084
Merged
Fix operator RBAC rules #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludydoo
approved these changes
Jun 12, 2023
| kind: ClusterRole | ||
| metadata: | ||
| name: rhacs-operator | ||
| namespace: stackrox-operator |
There was a problem hiding this comment.
I think this is superfluous for cluster-scoped resources
| subjects: | ||
| - kind: ServiceAccount | ||
| name: rhacs-operator-controller-manager | ||
| namespace: stackrox-operator |
There was a problem hiding this comment.
No, stackrox-operator is currently used for the operator deployment. It changes eventually to rhacs.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ludydoo, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix RBAC operator rules in fleetshard deployment.
These were missing when the fleetshard-based installation was introducded.
Currently this operator installation is protected by a feature flag and not used in production.
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual