-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-15234: Prometheus metric for pause-reconcile instances #1065
Conversation
@@ -36,10 +36,11 @@ const ( | |||
FreeStatus int32 = iota | |||
BlockedStatus | |||
|
|||
PauseReconcileAnnotation = "stackrox.io/pause-reconcile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be exported here instead, so that we don't duplicate the annotation. Will do in a follow-up, if it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wait for @stehessel review?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, SimonBaeumer, stehessel, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds a Prometheus metric that exposes the pause-reconcile instances managed by fleetshard-sync.
The metric is implemented as a Gauge, where value 1 means an instance is pause-reconcile'd, and 0 means it's not. Values are labeled by the instance name.
See also stackrox/rhacs-observability-resources#102
Checklist (Definition of Done)
Added test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
Manual testing:
Then opened
http://localhost:8080/metrics
in a browser and checked that the new metrics are there and have correct values, before and after adding the pause-reconcile annotation, e.g.: