-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-16735: Add vector.dev
Helm chart
#1038
Conversation
Skipping CI for Draft Pull Request. |
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should adjust a few configurations for the vector aggregator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress! I've added a few additional suggestions related to the configuration of Vector. Please look at it by yourself if something can be even more improved.
Maybe there are some good suggestions here: https://vector.dev/docs/setup/going-to-prod/arch/aggregator/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need a minor tweak for matchExpressions
.
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can go forward and merge this. The next step will be to adjust some settings and enable vector.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0x656b694d, mtodor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
Persistent volumes:
Vector deployment container:
HTTPS config:
Test logs: https://s3.console.aws.amazon.com/s3/buckets/acs-audit-logs--us-east-1--acs-dev-dp-01?prefix=test-tenant-id/2023-05-22/®ion=us-east-1