ROX-16507: Download ACS Operator CRDs dynamically #1010
Conversation
|
Skipping CI for Draft Pull Request. |
kurlov
requested review from
SimonBaeumer and
johannes94
and removed request for
johannes94
| @@ -92,3 +97,12 @@ func TestInstallOrUpdateChartUpdateExisting(t *testing.T) { | |||
| assert.NotEmpty(t, res.GetLabels()) | |||
| assert.Equal(t, "baz", res.GetLabels()["foo"]) | |||
| } | |||
|
|
|||
| func TestGetChartWithDynamicTemplate(t *testing.T) { | |||
| crdURL := "https://raw.githubusercontent.com/stackrox/stackrox/master/operator/bundle/manifests/platform.stackrox.io_securedclusters.yaml" | |||
There was a problem hiding this comment.
Can you make the URL configurable?
There was a problem hiding this comment.
The URL will be dynamic (containing release tag)
There was a problem hiding this comment.
The URL should be configurable so that we don't need to rebuild fleetshard to change the download source.
| @@ -92,3 +97,12 @@ func TestInstallOrUpdateChartUpdateExisting(t *testing.T) { | |||
| assert.NotEmpty(t, res.GetLabels()) | |||
| assert.Equal(t, "baz", res.GetLabels()["foo"]) | |||
| } | |||
|
|
|||
| func TestGetChartWithDynamicTemplate(t *testing.T) { | |||
| crdURL := "https://raw.githubusercontent.com/stackrox/stackrox/master/operator/bundle/manifests/platform.stackrox.io_securedclusters.yaml" | |||
There was a problem hiding this comment.
The URL should be configurable so that we don't need to rebuild fleetshard to change the download source.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Make Fleetshard-sync download the latest Central and SecuredCluster CRDs version from the main stackrox repository.
CRDs download in memory to avoid creating them in the
embed.FS. Because of that the load chart functions had to be adjusted to support both static and dynamic chart file sourcesChecklist (Definition of Done)
Test manual- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.- [ ] Add secret to app-interface Vault or Secrets Manager if necessaryTest manual