Add the make secrets/touch command to ensure all secret files exist. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mment them out because otherwise it breaks lint and tests
…suppress nag echo messages when running lint and tests
SimonBaeumer
reviewed
Apr 7, 2022
| @@ -450,6 +451,36 @@ test/run: image/build/test | |||
| docker run -u $(shell id -u) --net=host -p 9876:9876 -i "$(test_image)" | |||
| .PHONY: test/run | |||
|
|
|||
| # Touch all necessary secret files for fleet manager to start up | |||
| secrets/touch: | |||
SimonBaeumer
approved these changes
Apr 7, 2022
… on missing secrets/sentry.key file
rhybrillou
added a commit
that referenced
this pull request
Sep 20, 2023
rhybrillou
added a commit
that referenced
this pull request
Oct 2, 2023
rhybrillou
added a commit
that referenced
this pull request
Oct 13, 2023
rhybrillou
added a commit
that referenced
this pull request
Oct 19, 2023
rhybrillou
added a commit
that referenced
this pull request
Oct 19, 2023
rhybrillou
added a commit
that referenced
this pull request
Nov 2, 2023
rhybrillou
added a commit
that referenced
this pull request
Nov 2, 2023
rhybrillou
added a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested: Ran the command, confirmed secrets created (
./fleet-manager servedidn't complain about missing secrets)Seemingly unrelated tidying is to fix the lint and test presubmits (reorder dependencies, bump dependency for linting openapi section of code, etc.)