fix reconciler unit tests

stackrox · Aug 1, 2023 · ee8b5ae · ee8b5ae
1 parent 4ad49c1
commit ee8b5ae
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/fleetshard/pkg/central/reconciler/reconciler.go b/fleetshard/pkg/central/reconciler/reconciler.go
@@ -665,6 +665,7 @@ func (r *CentralReconciler) collectReconciliationStatus(ctx context.Context, rem
 		}
 	}
 
+	// Only store secrets if central was ready once to ensure we're not trying to get secrets before they are created
 	if isRemoteCentralReady(remoteCentral) {
 		secrets, err := r.collectSecretsEncrypted(ctx, remoteCentral)
 		if err != nil {

diff --git a/fleetshard/pkg/central/reconciler/reconciler_test.go b/fleetshard/pkg/central/reconciler/reconciler_test.go
@@ -434,6 +434,18 @@ func TestIgnoreCacheForCentralForceReconcileAlways(t *testing.T) {
 			},
 		},
 		centralDeploymentObject(),
+		&v1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "central-tls",
+				Namespace: centralNamespace,
+			},
+		},
+		&v1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "central-db-password",
+				Namespace: centralNamespace,
+			},
+		},
 	)
 
 	managedCentral := simpleManagedCentral