fix(probe): improve probe logging (#1243)

stackrox · Sep 7, 2023 · 6a4e305 · 6a4e305
1 parent f283048
commit 6a4e305
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/probe/pkg/probe/probe.go b/probe/pkg/probe/probe.go
@@ -145,7 +145,7 @@ func (p *ProbeImpl) createCentral(ctx context.Context) (*public.CentralRequest,
 	central, resp, err := p.fleetManagerPublicAPI.CreateCentral(ctx, true, request)
 	defer utils.IgnoreError(closeBodyIfNonEmpty(resp))
 	if central.Id == "" {
-		glog.Infof("creation of central instance requested - got empty response", central.Id)
+		glog.Info("creation of central instance requested - got empty response")
 	} else {
 		glog.Infof("creation of central instance (%s) requested", central.Id)
 	}

diff --git a/probe/pkg/runtime/runtime.go b/probe/pkg/runtime/runtime.go
@@ -41,7 +41,7 @@ func (r *Runtime) RunLoop(ctx context.Context) error {
 			return errors.Wrap(ctx.Err(), "probe context invalid")
 		case <-ticker.C:
 			if err := r.RunSingle(ctx); err != nil {
-				glog.Warning(err)
+				glog.Error(err)
 			}
 		}
 	}
@@ -74,7 +74,7 @@ func (r *Runtime) RunSingle(ctx context.Context) (errReturn error) {
 	if err := r.probe.Execute(probeRunCtx); err != nil {
 		metrics.MetricsInstance().IncFailedRuns(r.Config.DataPlaneRegion)
 		metrics.MetricsInstance().SetLastFailureTimestamp(r.Config.DataPlaneRegion)
-		glog.Error("probe run failed", err)
+		glog.Error("probe run failed: ", err)
 		return errors.Wrap(err, "probe run failed")
 	}
 	metrics.MetricsInstance().IncSucceededRuns(r.Config.DataPlaneRegion)