Support disabling inactive links #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I20a78d7ff336dc337a5532637cd1efca55c4c79a
Change-Id: Iba0cd96565e51320a25aa597a36b38f99ca1a398
Change-Id: I7911379d88305bb8d2c6ffccb1f56982156fdb3f
Currently, when a port is unbound by NGS, this is typically implemented by removing the VLAN association from the corresponding switch interface. This puts the interface on the default VLAN of the switch, and leaves it administratively up (active). This may be an issue in some scenarios, such as: * If there is more than one interface on the server, subsequent instances may choose not to attach a network to one or more interfaces. If these interfaces are active on a default VLAN this would be a security hole. * If configuration of an interface fails but is silently ignored by NGS, the interface will remain on the default VLAN. To avoid these issues this change adds support for administratively disabling ports when they are not in use. This behaviour is optional, since it might not be appropriate on all devices or in all scenarios. Configuration of the behaviour is controlled by a per-device config flag, 'ngs_disable_inactive_ports'. Change-Id: Ibdbb871d7f3e9ad0d3ade1049cc09a2da5e36fab Story: 2003391 Task: 24511
Adds the necessary code to the Juniper Junos device driver to support disabling inactive links. This feature is enabled by setting the per-device config flag 'ngs_disable_inactive_ports'. Change-Id: I636613d0c910d10601422ad094f835c17a606e37 Story: 2003391 Task: 24933
oneswig
approved these changes
Aug 31, 2018
|
@oneswig good question, but no there are not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.