Support 802.3ad port groups on Cumulus devices (Wallaby backport) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ic3e10d19315b776662188f41c552fe0676a12782, multiple links in a port group are configured. This typically works for bond modes that do not require switch-side configuration, such as active/passive, TLB and ALB. In some cases this may also work for 802.3ad link aggregates, if local_link_connection.port_id in the ports is set to the name of the port group interface. However some switches require different commands to be used when configuring port groups vs switch port interfaces. For example, NVIDIA Cumulus switches require to use 'net add bond...' instead of 'net add interface ...'. This change adds support for devices that require different commands to configure port groups, and provides an implementation for NVIDIA Cumulus switches. Closes-Bug: #1976382 Related-Bug: #1759000 Change-Id: I0693c495170aa821a2f571038f387c50a2f6c599
markgoddard
changed the title
cityofships
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream: https://review.opendev.org/c/openstack/networking-generic-switch/+/844062
Since Ic3e10d19315b776662188f41c552fe0676a12782, multiple links in a
port group are configured. This typically works for bond modes that do
not require switch-side configuration, such as active/passive, TLB and
ALB.
In some cases this may also work for 802.3ad link aggregates, if
local_link_connection.port_id in the ports is set to the name of the
port group interface. However some switches require different commands
to be used when configuring port groups vs switch port interfaces. For
example, NVIDIA Cumulus switches require to use 'net add bond...'
instead of 'net add interface ...'.
This change adds support for devices that require different commands to
configure port groups, and provides an implementation for NVIDIA Cumulus
switches.
Closes-Bug: #1976382
Related-Bug: #1759000
Change-Id: I0693c495170aa821a2f571038f387c50a2f6c599