Batching ported to victoria release #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Doug Szumski <[email protected]> Closes-Bug: #1903891 Change-Id: I7ed26a391ca12c3cadb078d40111639fd355fe74 (cherry picked from commit f9900d2)
When you have around 60 baremetal nodes attached to a single switch, it takes a long time to execute all those commands. This gets worse when you limit the number of concurrent ssh connections. Here we look to batch up commands to send to the switch together, then wait for them all to complete before returning the result. It does this by using etcd keys as a queueing system. We pull off the queue using the version at which the keys were added, giving a FIFO style queue. Change-Id: I8c458bbc94df5630cfede5434bcdbe527988059c (cherry picked from commit 95ad991ca824fd3a9f08ab4f266e65d33542f9a8) Conflicts: lower-constraints.txt
This allows operators to opt out of NGS adding or removing VLANs from switches. This is useful when not all switch configuration is being managed by Networking Generic Switch. A similar concenpt is already supported by ansible-networking: https://opendev.org/x/networking-ansible/src/commit/6f56fd45425141e5435884d2d0cf88ee96a887c6/etc/neutron/plugins/ml2/ml2_conf_ansible.ini.sample Change-Id: I271263a349d6cccd0fe9980e10b1b8d5fd86716e (cherry picked from commit d6b4d63)
Cumulus config often means you need the password and secret in the netmiko configuration. This can mean leaking the password into the logs. This fix helps avoid that problem. Change-Id: If90db5aab581a6944dbc87b9f83a5583a80189b9 (cherry picked from commit 9286784)
Conflicts: networking_generic_switch/devices/netmiko_devices/juniper.py Change-Id: I9d59ff09a4392229710a9602ee52efa7e8faf753
markgoddard
approved these changes
May 17, 2021
| @@ -0,0 +1,335 @@ | |||
| # Copyright 2020 StackHPC | |||
|
are we merging that? @jovial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.