Upgrade to git2 0.15 #206
Merged
Upgrade to git2 0.15 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 0.13, a few changes have been made to git2, including rust-lang/git2-rs#791 which should address the extensions.worktreeConfig issue in #195. The upgrade required fixing uses of [ConfigEntries][1] because it's no longer an iterator. [1]: https://docs.rs/git2/0.15.0/git2/struct.ConfigEntries.html However, it provides an API that lends itself well to `while let` to provide a for loop like experience, so this was an easy fix.
abhinav
commented
Sep 9, 2022
| let entry = entry?; | ||
| if let Some(name) = entry.name() { | ||
| config_to_delete.push(name.to_string()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Note, this extra { ... } is required to limit the lifetime of ConfigEntries so that config can be borrowed mutably again below for config.remove.
|
Thanks, @abhinav! I'm a little embarrassed to not have noticed that StGit had gotten so behind on |
|
NP! Credit goes to @NonLogicalDev for finding out that this was fixed upstream.
GitHub's dependabot supports Cargo, if that's something you're willing to use. version: 2
updates:
- package-ecosystem: "cargo"
directory: "/"
schedule:
interval: "weekly" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0.13, git2 has seen many changes, including rust-lang/git2-rs#791
which should address the extensions.worktreeConfig issue in #195.
The upgrade required fixing uses of ConfigEntries because it's no
longer an iterator.
However, it provides an API that lends itself well to a
while letstatement,which provides a for-loop-like experience, so the fix was straightforward.