-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove background color transitions from dark/light switch #53
fix: remove background color transitions from dark/light switch #53
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for stackblitz-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'd prefer if we could address the issue upstream in Vitepress. |
Tried it in the preview deploy, and it does feel like a small improvement. Given that it's not a big fix, I think it would be okay to have this in our @sylwiavargas what do you think? |
Hi @kevinzunigacuellar! Thank you for the contribution - and for being the first external contributor to make a PR using Codeflow! 💙 @kevinzunigacuellar would you like to raise an issue with VitePress (we are using VitePress default theme)? We can do that as well but since this is your "find", wanted to ask you :) |
hello @sylwiavargas thank you for accepting my PR 🚀. I can raise an issue to VitePress and link the issue here to track its progress. I wanted to try codeflow and it was very smooth (love it 🦄). I will start using it all the time btw. I don't know if the offer of joining the contributor list is still open but if it is I would love to be part of it. Once again thank you and @fvsch for taking the time to review my PR. Have a nice day |
vuejs/vitepress#1479 got merged 🥳 |
PR Description
This PR fixes the issue number: #52
Summary of my changes and explanation of my decisions
background-color
transitionsSelf-check
Please check all that apply:
Contributors list
Would you like your contribution to be celebrated? Please check all that apply:
(~idk 😅) I was testing out codeflow
I would like to be featured on the future contributors list in the README. If so, please tell us:
I would like to get a shoutout in the next monthly updates post. If so, please provide your twitter handle (or we will link to your GitHub profile).
⚡️ ⚡️ ⚡️ Thank you for contributing to StackBlitz ⚡️ ⚡️ ⚡️