Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ports from Role CRD #76

Merged
merged 6 commits into from
Dec 23, 2021
Merged

Remove Ports from Role CRD #76

merged 6 commits into from
Dec 23, 2021

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 22, 2021 •
edited by maltesander
Loading

Description

Without the agent, ports don't need to be configurable anymore

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

maltesander
maltesander requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one unwrap comment and the zookeeper references in the custom resource examples go for "simple" zk cluster. In the zookeeper example its called "simple-zk".

rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
maltesander
maltesander approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Dec 23, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 23, 2021

Build succeeded:

@bors bors bot merged commit 9e72a23 into main Dec 23, 2021
@bors bors bot deleted the port-changes branch December 23, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @maltesander