Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Set explicit resources on all containers #444

Closed
wants to merge 14 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 6, 2023

Description

Part of: stackabletech/issues#394

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan changed the title Smoke tests with resource quotas Set explicit resources on all containers Jun 27, 2023
@sbernauer sbernauer changed the title Set explicit resources on all containers feat: Set explicit resources on all containers Jun 28, 2023
@razvan razvan self-assigned this Jun 28, 2023
@razvan razvan marked this pull request as ready for review June 29, 2023 06:09
@razvan razvan requested a review from a team June 29, 2023 06:09
@sbernauer sbernauer self-assigned this Jun 29, 2023
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things

tests/templates/kuttl/smoke/30-install-zk.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/smoke/40-install-hdfs.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/smoke/50-install-druid.yaml.j2 Outdated Show resolved Hide resolved
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@razvan
Copy link
Member Author

razvan commented Jun 29, 2023

Latest tests pass

--- PASS: kuttl (2419.95s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/hdfs-deep-storage_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (445.72s)
        --- PASS: kuttl/harness/logging_druid-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (520.83s)
        --- PASS: kuttl/harness/resources_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev (198.70s)
        --- PASS: kuttl/harness/ldap-authentication_druid-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_opa-0.45.0-stackable0.0.0-dev_hadoop-latest-3.3.4-stackable0.0.0-dev_ldap-use-tls-true_ldap-no-bind-credentials-false_openshift-true (352.87s)
        --- PASS: kuttl/harness/s3-deep-storage_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_s3-use-tls-true (314.49s)
        --- PASS: kuttl/harness/ingestion-s3-ext_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (396.33s)
        --- PASS: kuttl/harness/authorizer_druid-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_opa-0.45.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (376.75s)
        --- PASS: kuttl/harness/cluster-operation_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-latest-3.3.4-stackable0.0.0-dev (426.07s)
        --- PASS: kuttl/harness/tls_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_tls-mode-internal-and-server-tls-and-tls-client-auth_openshift-true (320.70s)
        --- PASS: kuttl/harness/orphans_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (405.80s)
        --- PASS: kuttl/harness/smoke_druid-26.0.0-stackable0.0.0-dev_zookeeper-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev_openshift-true (347.24s)
        --- PASS: kuttl/harness/ingestion-no-s3-ext_druid-latest-26.0.0-stackable0.0.0-dev_zookeeper-latest-3.8.0-stackable0.0.0-dev_hadoop-3.3.4-stackable0.0.0-dev (381.13s)

@razvan
Copy link
Member Author

razvan commented Jun 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 29, 2023
@sbernauer
Copy link
Member

bors cancel

@bors
Copy link
Contributor

bors bot commented Jun 29, 2023

Canceled.

@sbernauer
Copy link
Member

Sorry, missed that change

@razvan
Copy link
Member Author

razvan commented Jun 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 29, 2023
@razvan
Copy link
Member Author

razvan commented Jun 29, 2023

bors cancel

@bors
Copy link
Contributor

bors bot commented Jun 29, 2023

Canceled.

@razvan
Copy link
Member Author

razvan commented Jun 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jun 29, 2023
@bors
Copy link
Contributor

bors bot commented Jun 29, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Set explicit resources on all containers [Merged by Bors] - feat: Set explicit resources on all containers Jun 29, 2023
@bors bors bot closed this Jun 29, 2023
@bors bors bot deleted the feat/resource-quotas branch June 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants