-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Added functionality to mount extra volumes with files needed for ingestion tasks #415
Conversation
I have not tested this due to lack of knowledge around how best to configure this. @fhennig maybe we can take a look together at this some time? |
Co-authored-by: Sebastian Bernauer <[email protected]>
I would prefer putting |
Agreed, I think. |
I figured since we discussed the NiFi CRD changes on Wednesday and these are pretty similar I could ride the coattails of that discussion :) Regarding clusterConfig .. I have no strong preference either way tbh. To my mind Since its two against one I'll change it. |
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
bors r+ |
…stion tasks (#415) # Description Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs.. This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion. It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434 Co-authored-by: Sönke Liebau <[email protected]>
Build failed: |
bors r+ |
…stion tasks (#415) # Description Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs.. This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion. It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434 Co-authored-by: Sönke Liebau <[email protected]>
Pull request successfully merged into main. Build succeeded: |
Description
Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs..
This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion.
It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434
Definition of Done Checklist
Author
Reviewer
Acceptance
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information