Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Added functionality to mount extra volumes with files needed for ingestion tasks #415

Closed
wants to merge 12 commits into from

Conversation

soenkeliebau
Copy link
Member

Description

Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs..

This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion.

It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@soenkeliebau
Copy link
Member Author

I have not tested this due to lack of knowledge around how best to configure this. @fhennig maybe we can take a look together at this some time?

docs/modules/druid/pages/usage.adoc Outdated Show resolved Hide resolved
rust/operator-binary/src/druid_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/druid_controller.rs Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member

I would prefer putting extraVolumes below clusterConfig. WDYT?
In general presenting this CRD change in Arch meeting would be great, not sure how the prio is though

@nightkr
Copy link
Member

nightkr commented Mar 16, 2023

I would prefer putting extraVolumes below clusterConfig. WDYT?

Agreed, I think.

@soenkeliebau
Copy link
Member Author

I would prefer putting extraVolumes below clusterConfig. WDYT? In general presenting this CRD change in Arch meeting would be great, not sure how the prio is though

I figured since we discussed the NiFi CRD changes on Wednesday and these are pretty similar I could ride the coattails of that discussion :)

Regarding clusterConfig .. I have no strong preference either way tbh. To my mind clusterConfig was a place to put setting that influence how the product works, whereas I thought of this as more of a "plumbing thing to get the environment right" .... but I think either would make sense.

Since its two against one I'll change it.

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Bernauer <[email protected]>
@soenkeliebau
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 16, 2023
…stion tasks (#415)

# Description
Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs..

This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion.

It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434



Co-authored-by: Sönke Liebau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 16, 2023

Build failed:

@soenkeliebau
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 16, 2023
…stion tasks (#415)

# Description
Druid can run ingestions tasks and sometimes it is necessary to supply files for configuring these tasks, like certificates or keytabs..

This PR allows specifying extra volumes that will be added to middlemanager pods as mounts, so that these files can be used when configuring Druid ingestion.

It has been closely modelled (read that as copied and pasted) from stackabletech/nifi-operator#434



Co-authored-by: Sönke Liebau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 16, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added functionality to mount extra volumes with files needed for ingestion tasks [Merged by Bors] - Added functionality to mount extra volumes with files needed for ingestion tasks Mar 16, 2023
@bors bors bot closed this Mar 16, 2023
@bors bors bot deleted the feat/extra_volumes branch March 16, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants