Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bump operator-rs to 0.27.1 #347

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - bump operator-rs to 0.27.1 #347

wants to merge 3 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Nov 21, 2022 •
edited by razvan
Loading

Description

Fixes #344.
✔️ CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/43/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 marked this pull request as ready for review November 21, 2022 16:14
@razvan razvan self-requested a review November 21, 2022 16:33
razvan
razvan reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG entry is missing.

deploy/manifests/crds.yaml
Comment on lines 1 to +2
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i have the same with HBase, not sure where this is coming from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to get rid of these anyway.

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
razvan
razvan approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@adwk67
Copy link
Member Author

adwk67 commented Nov 21, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 21, 2022
@adwk67
bump operator-rs to 0.27.1 (#347)
37abe8e 
# Description

Fixes #344.
:heavy_check_mark: CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/43/
@bors
Copy link
Contributor

bors bot commented Nov 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bump operator-rs to 0.27.1 [Merged by Bors] - bump operator-rs to 0.27.1 Nov 21, 2022
@bors bors bot closed this Nov 21, 2022
@bors bors bot deleted the bump-oprs-0271 branch November 21, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander left review comments

@razvan razvan razvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump operator-rs to 0.27.1
3 participants
@adwk67 @razvan @maltesander