Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Support tls encryption and authentication #333

Closed
wants to merge 49 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
2df5c34
wip adapted CRD
maltesander Oct 18, 2022
9c98a2a
adapted crds, added tls properties
maltesander Oct 18, 2022
1bb0ea0
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
maltesander Oct 19, 2022
57d3783
adapted tests and examples
maltesander Oct 19, 2022
ade2d85
adapted docs to new structure
maltesander Oct 19, 2022
5fdf74d
wip - started tests
maltesander Oct 19, 2022
07bcdbe
code cleanup
maltesander Oct 19, 2022
9542070
more restructureing
maltesander Oct 20, 2022
3cce94a
wip
maltesander Oct 20, 2022
16ab4a4
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
maltesander Oct 25, 2022
7ed6b6a
wip
maltesander Oct 25, 2022
967f8cc
wip
maltesander Oct 25, 2022
f514b5d
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
maltesander Oct 26, 2022
fed8806
wip
maltesander Oct 26, 2022
a57ce39
removed internal tls for now. started tests.
maltesander Oct 28, 2022
3b706dc
tls tests working
maltesander Oct 30, 2022
4acc745
authentication working
maltesander Nov 2, 2022
e46da68
working on tests
maltesander Nov 2, 2022
3a59475
switched to clusterConfig
maltesander Nov 3, 2022
aab5ed5
wip
maltesander Nov 3, 2022
6665156
wip
maltesander Nov 4, 2022
6b35031
first tests passing after rework
maltesander Nov 4, 2022
2a022f4
adapted other tests to new crd structure
maltesander Nov 6, 2022
b5b3655
adapted docs
maltesander Nov 6, 2022
870b494
updated test definition
maltesander Nov 6, 2022
484c269
adapted changelog
maltesander Nov 6, 2022
7ffe15e
added example
maltesander Nov 7, 2022
2fb3181
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
maltesander Nov 7, 2022
55989bb
first merging
maltesander Nov 7, 2022
b2a5a9a
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
maltesander Nov 7, 2022
2c13892
local tests working - adapted probes
maltesander Nov 7, 2022
536f5f2
fix cargo tests
maltesander Nov 7, 2022
a43e566
clippy
maltesander Nov 7, 2022
8b83265
Apply suggestions from code review
maltesander Nov 7, 2022
980b268
yaml lints
maltesander Nov 7, 2022
195c99c
Merge remote-tracking branch 'origin/support_tls_authentication' into…
maltesander Nov 7, 2022
ed484f6
Removed copy paste trino reference
maltesander Nov 7, 2022
34af569
added authentication class permissions
maltesander Nov 7, 2022
a324954
Merge remote-tracking branch 'origin/main' into support_tls_authentic…
maltesander Nov 10, 2022
3efdb86
fix changelog
maltesander Nov 10, 2022
c148abd
fixed tls example with missing zk / hdfs cluster and znodes
maltesander Nov 10, 2022
33b99d2
removed role from common_compute_files
maltesander Nov 10, 2022
a1ff844
added unit tests for tls properties
maltesander Nov 10, 2022
d0ab6ab
tried to clarify that internal and external encryption / authenticati…
maltesander Nov 10, 2022
20ac94b
fix typo
maltesander Nov 10, 2022
08413cd
reusing CERTS_DIR constant instead of hardcoded directory
maltesander Nov 10, 2022
8e6bab3
Switched TLS tests to use s3 deep storage and TLS
maltesander Nov 11, 2022
16b5ef5
enable all tests
maltesander Nov 11, 2022
9e7f0c1
Update tests/templates/kuttl/tls/01-install-minio-certificates.yaml.j2
maltesander Nov 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Added

- BREAKING: Support for TLS encryption (activated per default -> port changes) and TLS authentication ([#333]).
- BREAKING: Reworked top level configuration. Deep storage, Ingestion spec, discovery config maps etc. are now subfields of `spec.clusterConfig` instead of being top level under `spec` ([#333]).

[#333]: https://github.com/stackabletech/druid-operator/pull/333

## [0.8.0] - 2022-11-07

### Added
Expand Down
38 changes: 31 additions & 7 deletions deploy/config-spec/properties.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ spec:

properties:

- property: &plaintext
- property: &plaintextPort
propertyNames:
- name: "druid.plaintext"
- name: "druid.plaintextPort"
kind:
type: "file"
file: "runtime.properties"
Expand All @@ -38,15 +38,39 @@ properties:
unit: *unitPort
roles:
- name: "broker"
required: true
required: false
- name: "coordinator"
required: true
required: false
- name: "historical"
required: true
required: false
- name: "middleManager"
required: true
required: false
- name: "router"
required: true
required: false
asOfVersion: "0.0.0"

- property: &tlsPort
propertyNames:
- name: "druid.tlsPort"
kind:
type: "file"
file: "runtime.properties"
datatype:
type: "integer"
min: "1"
max: "65535"
unit: *unitPort
roles:
- name: "broker"
required: false
- name: "coordinator"
required: false
- name: "historical"
required: false
- name: "middleManager"
required: false
- name: "router"
required: false
asOfVersion: "0.0.0"

- property: &startupLoggingLogProperties
Expand Down
622 changes: 332 additions & 290 deletions deploy/crd/druidcluster.crd.yaml

Large diffs are not rendered by default.

38 changes: 31 additions & 7 deletions deploy/helm/druid-operator/configs/properties.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ spec:

properties:

- property: &plaintext
- property: &plaintextPort
propertyNames:
- name: "druid.plaintext"
- name: "druid.plaintextPort"
kind:
type: "file"
file: "runtime.properties"
Expand All @@ -38,15 +38,39 @@ properties:
unit: *unitPort
roles:
- name: "broker"
required: true
required: false
- name: "coordinator"
required: true
required: false
- name: "historical"
required: true
required: false
- name: "middleManager"
required: true
required: false
- name: "router"
required: true
required: false
asOfVersion: "0.0.0"

- property: &tlsPort
propertyNames:
- name: "druid.tlsPort"
kind:
type: "file"
file: "runtime.properties"
datatype:
type: "integer"
min: "1"
max: "65535"
unit: *unitPort
roles:
- name: "broker"
required: false
- name: "coordinator"
required: false
- name: "historical"
required: false
- name: "middleManager"
required: false
- name: "router"
required: false
asOfVersion: "0.0.0"

- property: &startupLoggingLogProperties
Expand Down
622 changes: 332 additions & 290 deletions deploy/helm/druid-operator/crds/crds.yaml

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions deploy/helm/druid-operator/templates/roles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,11 @@ rules:
- get
- list
- watch
- apiGroups:
- authentication.stackable.tech
resources:
- authenticationclasses
verbs:
- get
- list
- watch
38 changes: 31 additions & 7 deletions deploy/manifests/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ data:

properties:

- property: &plaintext
- property: &plaintextPort
propertyNames:
- name: "druid.plaintext"
- name: "druid.plaintextPort"
kind:
type: "file"
file: "runtime.properties"
Expand All @@ -42,15 +42,39 @@ data:
unit: *unitPort
roles:
- name: "broker"
required: true
required: false
- name: "coordinator"
required: true
required: false
- name: "historical"
required: true
required: false
- name: "middleManager"
required: true
required: false
- name: "router"
required: true
required: false
asOfVersion: "0.0.0"

- property: &tlsPort
propertyNames:
- name: "druid.tlsPort"
kind:
type: "file"
file: "runtime.properties"
datatype:
type: "integer"
min: "1"
max: "65535"
unit: *unitPort
roles:
- name: "broker"
required: false
- name: "coordinator"
required: false
- name: "historical"
required: false
- name: "middleManager"
required: false
- name: "router"
required: false
asOfVersion: "0.0.0"

- property: &startupLoggingLogProperties
Expand Down
Loading