Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove the hardcoded config properties #195

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - Remove the hardcoded config properties #195

wants to merge 13 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Mar 9, 2022 •
edited
Loading

Description

  • some properties I could not find in the configuration reference, I removed them without replacement
  • some properties have sensible defaults, often computed from e.g. available cores. In those cases I just removed the property, making us use the calculated default
  • some properties I moved to the product-config

fixes #28

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig marked this pull request as ready for review March 15, 2022 12:19
@fhennig fhennig requested a review from a team March 15, 2022 12:20
maltesander
maltesander approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Mar 15, 2022

bors merge

bors bot pushed a commit that referenced this pull request Mar 15, 2022
@fhennig
Remove the hardcoded config properties (#195)
465fb0b 
## Description

- some properties I could not find in the configuration reference, I removed them without replacement
- some properties have sensible defaults, often computed from e.g. available cores. In those cases I just removed the property, making us use the calculated default
- some properties I moved to the product-config

fixes #28
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove the hardcoded config properties [Merged by Bors] - Remove the hardcoded config properties Mar 15, 2022
@bors bors bot closed this Mar 15, 2022
@bors bors bot deleted the config-rework branch March 15, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring config.rs (hard-coded config properties)
2 participants
@fhennig @maltesander