-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Removed namespace for zookeeper cluster #140
Conversation
deploy/manifests/crds.yaml
Outdated
@@ -544,7 +536,7 @@ spec: | |||
- middleManagers | |||
- routers | |||
- version | |||
- zookeeperReference | |||
- zookeeperCluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other operators (kafka, hdfs) seem to have standardized on zookeeperConfigMapName
for this because it could refer to either a ZNode or a Zookeeper cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a very good name I believe but I'll change it for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested locally with integration tests.
great thank you! |
bors merge |
## Description This PR removes the `namespace` field for the zookeeper reference; i.e. it is now not required to specify a namespace, instead the operator looks for the discovery config map in the same namespace as the druid cluster is. This is the intended behaviour and also necessary for the kuttl tests to work. ## Review Checklist - [x] Code contains useful comments - [x] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests) Co-authored-by: Stacky McStackface <[email protected]>
Pull request successfully merged into main. Build succeeded: |
Description
This PR removes the
namespace
field for the zookeeper reference; i.e. it is now not required to specify a namespace, instead the operator looks for the discovery config map in the same namespace as the druid cluster is.This is the intended behaviour and also necessary for the kuttl tests to work.
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information