-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Initial Operator Implementation #13
Conversation
I just realized that to try it out yourself, you need to install the package manually since it isn't in the nexus - respectively the nexus version doesn't contain the custom startup script. |
Okay, it was decided that the operator will be reviewed with the changes made to use the docker images already, I'll finish that up and add it to this pull request. |
looks good to me at this point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly left over commented code.
assets = [ | ||
["../../target/release/stackable-druid-operator", "opt/stackable/druid-operator/", "755"], | ||
["../../deploy/crd/druidcluster.crd.yaml", "etc/stackable/druid-operator/crd/", "644"], | ||
["../../deploy/config-spec/properties.yaml", "etc/stackable/druid-operator/config-spec/", "644"], | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required anymore, just for completeness:
["../../deploy/crd/restart.crd.yaml", "etc/stackable/druid-operator/crd/", "644"],
["../../deploy/crd/start.crd.yaml", "etc/stackable/druid-operator/crd/", "644"],
["../../deploy/crd/stop.crd.yaml", "etc/stackable/druid-operator/crd/", "644"],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole package.metadata.deb can be removed right? We don't build debian packages anymore I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh now I see what you meant
let runtime_properties = get_runtime_properties(role, &transformed_config); | ||
cm_conf_data.insert(RUNTIME_PROPS.to_string(), runtime_properties); | ||
} | ||
PropertyNameKind::File(file_name) if file_name == JVM_CONFIG => { | ||
let jvm_config = get_jvm_config(role); | ||
cm_conf_data.insert(JVM_CONFIG.to_string(), jvm_config); | ||
} | ||
PropertyNameKind::File(file_name) if file_name == LOG4J2_CONFIG => { | ||
let log_config = get_log4j_config(role); | ||
cm_conf_data.insert(LOG4J2_CONFIG.to_string(), log_config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way this is build we never actually use the config overrides.
Please check e.g. https://github.com/stackabletech/hdfs-operator/blob/aab7c8b190af3700656c4996ad89c2cbba63b7a8/rust/operator/src/lib.rs#L293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I'm working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think for the runtime properties the transformed_config is already used, so that should work right? And the other two are not templated, so it's not possible to implement there.
…ackabletech/operator-templating repo. Original commit message: Patch chart, docker and oprerator versions in pull-requests (#13) * Update trino clusterrole rules. * Patch versions on pull requests. * Moved Python script to subfolder * Fix retired files path. * Fix regorule ClusterRole and uncomment all repos. * Comment out restart-controler from repo list.
No description provided.