Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Dep upgrades #123

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Dep upgrades #123

wants to merge 5 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Jan 25, 2022

Description

Updated operator-rs to 0.8.0

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff

CHANGELOG.md Outdated
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.

### Changed

- Updated to operator-rs 0.8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this structure for updates (and add the PR number)
operator-rs 0.6.00.8.0

@@ -28,5 +28,5 @@ tracing = "0.1"

[build-dependencies]
built = { version = "0.5", features = ["chrono", "git2"] }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "0.7.0" }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "0.8.0" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structopt = "0.3" above can go

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Jan 25, 2022

bors merge

bors bot pushed a commit that referenced this pull request Jan 25, 2022
## Description

Updated operator-rs to 0.8.0
@bors
Copy link
Contributor

bors bot commented Jan 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Dep upgrades [Merged by Bors] - Dep upgrades Jan 25, 2022
@bors bors bot closed this Jan 25, 2022
@bors bors bot deleted the dep-upgrades branch January 25, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants